[PATCH 1/8] fsmonitor: prefer repo_git_path() to git_pathdup()
- From
Jeff King <peff@peff.net>
- Date
- Sep 18, 2023, 22:29 UTC
- Message-ID
- <20230918222940.GA2659298@coredump.intra.peff.net>
- In-Reply-To
- <20230918222908.GA2659096@coredump.intra.peff.net>
The fsmonitor_ipc__get_path() function ignores its repository argument. It should use it when constructing repo paths (though in practice, it is unlikely anything but the_repository is ever passed, so this is cleanup and future proofing, not a bug fix).
Note that despite the lack of "dup" in the name, repo_git_path() behaves like git_pathdup() and returns an allocated string.
Signed-off-by: Jeff King <peff@peff.net> --- compat/fsmonitor/fsm-ipc-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/compat/fsmonitor/fsm-ipc-win32.c b/compat/fsmonitor/fsm-ipc-win32.c index 8928fa93ce..41984ea48e 100644 --- a/compat/fsmonitor/fsm-ipc-win32.c +++ b/compat/fsmonitor/fsm-ipc-win32.c @@ -6,6 +6,6 @@ const char *fsmonitor_ipc__get_path(struct repository *r) { static char *ret; if (!ret) - ret = git_pathdup("fsmonitor--daemon.ipc"); + ret = repo_git_path(r, "fsmonitor--daemon.ipc"); return ret; }
-- 2.42.0.671.g43fbf3903a