git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/8] fsmonitor unused parameter cleanups

From
Jeff King <peff@peff.net>
Date
Sep 18, 2023, 22:29 UTC
Message-ID
<20230918222908.GA2659096@coredump.intra.peff.net>

Here are a few cleanups of the fsmonitor code to remove or annotate unused parameters (working towards my goal of making us compile clean with -Wunused-parameter). I think they should all be pretty non-controversial, but I'm cc-ing folks active in the area in case patch 2 steps on the toes of any unpublished works in progress.

  [1/8]: fsmonitor: prefer repo_git_path() to git_pathdup()
  [2/8]: fsmonitor/win32: drop unused parameters
  [3/8]: fsmonitor: mark some maybe-unused parameters
  [4/8]: fsmonitor/win32: mark unused parameter in fsm_os__incompatible()
  [5/8]: fsmonitor: mark unused parameters in stub functions
  [6/8]: fsmonitor/darwin: mark unused parameters in system callback
  [7/8]: fsmonitor: mark unused hashmap callback parameters
  [8/8]: run-command: mark unused parameters in start_bg_wait callbacks
 builtin/fsmonitor--daemon.c             | 10 ++++++----
 compat/fsmonitor/fsm-health-darwin.c    |  8 ++++----
 compat/fsmonitor/fsm-ipc-win32.c        |  2 +-
 compat/fsmonitor/fsm-listen-darwin.c    |  4 ++--
 compat/fsmonitor/fsm-listen-win32.c     | 24 ++++++++++--------------
 compat/fsmonitor/fsm-path-utils-win32.c |  7 ++++---
 compat/fsmonitor/fsm-settings-win32.c   |  2 +-
 fsmonitor-ipc.c                         | 10 +++++-----
 fsmonitor-settings.c                    |  3 ++-
 t/helper/test-simple-ipc.c              |  3 ++-
 10 files changed, 37 insertions(+), 36 deletions(-)
-Peff
Next: Jeff King
Message 1 of 11 in “fsmonitor unused parameter cleanups”
  1. 0/8 fsmonitor unused parameter cleanupsJeff King, Sep 18, 2023
  2. 1/8 fsmonitor: prefer repo_git_path() to git_pathdup()Jeff King, Sep 18, 2023
  3. 2/8 fsmonitor/win32: drop unused parametersJeff King, Sep 18, 2023
  4. 3/8 fsmonitor: mark some maybe-unused parametersJeff King, Sep 18, 2023
  5. 4/8 fsmonitor/win32: mark unused parameter in fsm_os__incompatible()Jeff King, Sep 18, 2023
  6. 5/8 fsmonitor: mark unused parameters in stub functionsJeff King, Sep 18, 2023
  7. 6/8 fsmonitor/darwin: mark unused parameters in system callbackJeff King, Sep 18, 2023
  8. 7/8 fsmonitor: mark unused hashmap callback parametersJeff King, Sep 18, 2023
  9. 8/8 run-command: mark unused parameters in start_bg_wait callbacksJeff King, Sep 18, 2023
  10. Jeff HostetlerSep 19, 2023
  11. Junio C HamanoSep 19, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.