git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] pull: only pass '--recurse-submodules' to subcommands

From
Philippe Blain <levraiphilippeblain@gmail.com>
Date
May 11, 2022, 22:35 UTC
Message-ID
<6e59a82c-22cc-8f0c-f7f7-94da59e8da89@gmail.com>
In-Reply-To
<xmqqzgjnhf5u.fsf@gitster.g>
Le 2022-05-11 à 18:34, Junio C Hamano a écrit :
Show 23 quoted lines
> Philippe Blain <levraiphilippeblain@gmail.com> writes:
> 
>>>     pull: only pass '--recurse-submodules' to subcommands
>>>     
>>>     Thanks for the debugging help :)
>>>     
>>>     Changes since v1:
>>>     
>>>      * add a test that actually tests the precedence of the config values
>>>        * I've kept the previous test; it has always worked, but it still
>>>          seems like a useful smoke test
>>>      * reworded the commit message slightly
>>
>> Thanks, this version looks good to me. I don't feel to strongly about the 
>> title either, so as you wish :)
> 
> Perhaps
> 
> 	pull: do not let submodule.recurse override fetch.recurseSubmodules
> 
> more clearly expresses what it wants to do (not passing the command
> line option is "how" we achieve that goal)?
> 
I like that title, yes.
Previous: Junio C HamanoNext: Glen Choo
Message 10 of 15 in “pull: only pass '--recurse-submodules' to subcommands”
  1. pull: only pass '--recurse-submodules' to subcommandsGlen Choo via GitGitGadget, May 9, 2022
  2. Junio C HamanoMay 10, 2022
  3. Junio C HamanoMay 10, 2022
  4. Philippe BlainMay 10, 2022
  5. Glen ChooMay 10, 2022
  6. Glen ChooMay 10, 2022
  7. pull: only pass '--recurse-submodules' to subcommandsGlen Choo via GitGitGadget, May 10, 2022
  8. Philippe BlainMay 11, 2022
  9. Junio C HamanoMay 11, 2022
  10. Philippe BlainMay 11, 2022
  11. Glen ChooMay 11, 2022
  12. Junio C HamanoMay 12, 2022
  13. pull: do not let submodule.recurse override fetch.recurseSubmodulesGlen Choo via GitGitGadget, May 11, 2022
  14. Junio C HamanoMay 12, 2022
  15. Philippe BlainMay 12, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.