Re: [PATCH v2] pull: only pass '--recurse-submodules' to subcommands

From: Glen Choo <chooglen@google.com>
Date: May 11, 2022, 23:21 UTC
Message-ID: <kl6ltu9vy7sc.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <6e59a82c-22cc-8f0c-f7f7-94da59e8da89@gmail.com>

Philippe Blain <levraiphilippeblain@gmail.com> writes:

Show 26 quoted lines

> Le 2022-05-11 à 18:34, Junio C Hamano a écrit :
>> Philippe Blain <levraiphilippeblain@gmail.com> writes:
>> 
>>>>     pull: only pass '--recurse-submodules' to subcommands
>>>>     
>>>>     Thanks for the debugging help :)
>>>>     
>>>>     Changes since v1:
>>>>     
>>>>      * add a test that actually tests the precedence of the config values
>>>>        * I've kept the previous test; it has always worked, but it still
>>>>          seems like a useful smoke test
>>>>      * reworded the commit message slightly
>>>
>>> Thanks, this version looks good to me. I don't feel to strongly about the 
>>> title either, so as you wish :)
>> 
>> Perhaps
>> 
>> 	pull: do not let submodule.recurse override fetch.recurseSubmodules
>> 
>> more clearly expresses what it wants to do (not passing the command
>> line option is "how" we achieve that goal)?
>> 
>
> I like that title, yes.

Hm, yes that makes more sense. The commit message leads with the bug, so it's more consistent to mention the bug in the title too.

It's arguably more _correct_ to say that passing only the CLI option is the desired result, and we just so happen to be fixing a bug along the way. But meh, the bug is roughly 90% [1] of the motivation for making this patch, so leading with the bug is ok.

Will reroll.

[1] The other 10% or so is some upcoming work with `git rebase --recurse-submodules` and supporting that in `git pull --rebase --recurse-submodules` :)