From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Wed, 11 May 2022 22:35:33 GMT
Subject: Re: [PATCH v2] pull: only pass '--recurse-submodules' to subcommands
Message-ID: <6e59a82c-22cc-8f0c-f7f7-94da59e8da89@gmail.com>
In-Reply-To: <xmqqzgjnhf5u.fsf@gitster.g>



Le 2022-05-11 à 18:34, Junio C Hamano a écrit :
> Philippe Blain <levraiphilippeblain@gmail.com> writes:
> 
>>>     pull: only pass '--recurse-submodules' to subcommands
>>>     
>>>     Thanks for the debugging help :)
>>>     
>>>     Changes since v1:
>>>     
>>>      * add a test that actually tests the precedence of the config values
>>>        * I've kept the previous test; it has always worked, but it still
>>>          seems like a useful smoke test
>>>      * reworded the commit message slightly
>>
>> Thanks, this version looks good to me. I don't feel to strongly about the 
>> title either, so as you wish :)
> 
> Perhaps
> 
> 	pull: do not let submodule.recurse override fetch.recurseSubmodules
> 
> more clearly expresses what it wants to do (not passing the command
> line option is "how" we achieve that goal)?
> 

I like that title, yes.