From: Johannes Sixt <j6t@kdbg.org>
Date: Wed, 10 Jan 2018 19:02:09 GMT
Subject: Re: [PATCH] t3900: add some more quotes
Message-ID: <6b32292b-0f71-7cf8-2069-41766d440b58@kdbg.org>
In-Reply-To: <20180110095832.22077-1-dev+git@drbeat.li>

Am 10.01.2018 um 10:58 schrieb Beat Bolli:
> In 89a70b80 ("t0302 & t3900: add forgotten quotes", 2018-01-03), quotes
> were added to protect against spaces in $HOME. In the test_when_finished
> hander, two files are deleted which must be quoted individually.
> 
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> ---
>   t/t3900-i18n-commit.sh | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/t/t3900-i18n-commit.sh b/t/t3900-i18n-commit.sh
> index 9e4e694d9..dc00db87b 100755
> --- a/t/t3900-i18n-commit.sh
> +++ b/t/t3900-i18n-commit.sh
> @@ -40,7 +40,7 @@ test_expect_success 'UTF-16 refused because of NULs' '
>   '
>   
>   test_expect_success 'UTF-8 invalid characters refused' '
> -	test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" &&
> +	test_when_finished "rm -f \"$HOME/stderr\" \"$HOME/invalid\"" &&

Should that not better be

	test_when_finished "rm -f \"\$HOME/stderr\" \"\$HOME/invalid\""

i.e., delay the expansion of $HOME to protect against double-quotes in 
the path?

-- Hannes