git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/8] scalar: enable built-in FSMonitor

From
Derrick Stolee <derrickstolee@github.com>
Date
Aug 19, 2022, 18:45 UTC
Message-ID
<6b1e154d-e90f-aed9-64c4-6e6845abe25c@github.com>
In-Reply-To
<pull.1324.v3.git.1660858853.gitgitgadget@gmail.com>
On 8/18/2022 5:40 PM, Victoria Dye via GitGitGadget wrote:
Show 23 quoted lines
> This series enables the built-in FSMonitor [1] on 'scalar'-registered
> repository enlistments. To avoid errors when unregistering an enlistment,
> the FSMonitor daemon is explicitly stopped during 'scalar unregister'.
> 
> Maintainer's note: this series has a minor conflict with
> 'vd/scalar-generalize-diagnose'. Please let me know if there's anything else
> I can provide (in addition to [2]) that would make resolution easier.
> 
> 
> Changes since V2
> ================
> 
>  * Updated prerequisites for FSMonitor in Scalar to include
>    'fsm_settings__get_reason(the_repository) == FSMONITOR_REASON_OK' to
>    handle cases where the platform is supported, but the repository is not.
>  * Gated enabling the 'core.fsmonitor' on FSMonitor compatibility with the
>    repo.
>  * Replaced 'die()' failures in 'delete_enlistment()' with 'error()'s.
>  * Replaced 'BUILTIN_FSMONITOR' test prerequisite with already-existing
>    'FSMONITOR_DAEMON' for FSMonitor.
>  * Rewrote Scalar enlistment/repo search in 'setup_enlistment_directory()'
>    to avoid unconstrained search and respect 'GIT_CEILING_DIRECTORIES'.
>    Added tests to show the new expected behavior.

I wrote a couple "thinking out loud" replies, but the series looks good to me without any changes.

Thanks, -Stolee

Previous: Johannes Schindelin via GitGitGadgetNext: Junio C Hamano
Message 38 of 39 in “scalar: enable built-in FSMonitor”
  1. 0/3 scalar: enable built-in FSMonitorVictoria Dye via GitGitGadget, Aug 16, 2022
  2. 1/3 scalar: enable built-in FSMonitor on `register`Matthew John Cheetham via GitGitGadget, Aug 16, 2022
  3. Junio C HamanoAug 16, 2022
  4. Victoria DyeAug 16, 2022
  5. Junio C HamanoAug 16, 2022
  6. 2/3 scalar unregister: stop FSMonitor daemonJohannes Schindelin via GitGitGadget, Aug 16, 2022
  7. 3/3 scalar: update technical doc roadmap with FSMonitor supportVictoria Dye via GitGitGadget, Aug 16, 2022
  8. Junio C HamanoAug 16, 2022
  9. Victoria DyeAug 16, 2022
  10. Junio C HamanoAug 16, 2022
  11. 0/5 scalar: enable built-in FSMonitorVictoria Dye via GitGitGadget, Aug 16, 2022
  12. 1/5 scalar-unregister: handle error codes greater than 0Victoria Dye via GitGitGadget, Aug 16, 2022
  13. Junio C HamanoAug 17, 2022
  14. 2/5 scalar-[un]register: clearly indicate source of errorVictoria Dye via GitGitGadget, Aug 16, 2022
  15. 5/5 scalar: update technical doc roadmap with FSMonitor supportVictoria Dye via GitGitGadget, Aug 16, 2022
  16. 3/5 scalar: enable built-in FSMonitor on `register`Matthew John Cheetham via GitGitGadget, Aug 16, 2022
  17. Derrick StoleeAug 17, 2022
  18. Junio C HamanoAug 17, 2022
  19. Victoria DyeAug 17, 2022
  20. Derrick StoleeAug 18, 2022
  21. Junio C HamanoAug 17, 2022
  22. 4/5 scalar unregister: stop FSMonitor daemonJohannes Schindelin via GitGitGadget, Aug 16, 2022
  23. Derrick StoleeAug 17, 2022
  24. Victoria DyeAug 17, 2022
  25. Derrick StoleeAug 17, 2022
  26. Derrick StoleeAug 17, 2022
  27. 0/8 scalar: enable built-in FSMonitorVictoria Dye via GitGitGadget, Aug 18, 2022
  28. 1/8 scalar: constrain enlistment searchVictoria Dye via GitGitGadget, Aug 18, 2022
  29. Derrick StoleeAug 19, 2022
  30. 2/8 scalar-unregister: handle error codes greater than 0Victoria Dye via GitGitGadget, Aug 18, 2022
  31. 3/8 scalar-[un]register: clearly indicate source of errorVictoria Dye via GitGitGadget, Aug 18, 2022
  32. 4/8 scalar-delete: do not 'die()' in 'delete_enlistment()'Victoria Dye via GitGitGadget, Aug 18, 2022
  33. 6/8 scalar: enable built-in FSMonitor on `register`Matthew John Cheetham via GitGitGadget, Aug 18, 2022
  34. Derrick StoleeAug 19, 2022
  35. 8/8 scalar: update technical doc roadmap with FSMonitor supportVictoria Dye via GitGitGadget, Aug 18, 2022
  36. 5/8 scalar: move config setting logic into its own functionVictoria Dye via GitGitGadget, Aug 18, 2022
  37. 7/8 scalar unregister: stop FSMonitor daemonJohannes Schindelin via GitGitGadget, Aug 18, 2022
  38. Derrick StoleeAug 19, 2022
  39. Junio C HamanoAug 19, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.