Re: [PATCH v3 6/8] scalar: enable built-in FSMonitor on `register`

From: Derrick Stolee <derrickstolee@github.com>
Date: Aug 19, 2022, 18:44 UTC
Message-ID: <3120a57c-3600-c583-7dd3-c13e2e4cdc52@github.com>
In-Reply-To: <fb379fd2097b1e4b18428d791b9bcd48571d7b73.1660858853.git.gitgitgadget@gmail.com>

On 8/18/2022 5:40 PM, Matthew John Cheetham via GitGitGadget wrote:

Show 6 quoted lines

> From: Matthew John Cheetham <mjcheetham@outlook.com>
> 
> Using the built-in FSMonitor makes many common commands quite a bit
> faster. So let's teach the `scalar register` command to enable the
> built-in FSMonitor and kick-start the fsmonitor--daemon process (for
> convenience).

Show 5 quoted lines

> +static int have_fsmonitor_support(void)
> +{
> +	return fsmonitor_ipc__is_supported() &&
> +	       fsm_settings__get_reason(the_repository) == FSMONITOR_REASON_OK;
> +}

The only thing I needed to check was that the_repository was initialized properly as part of 'scalar clone' and it indeed is.

Thanks, -Stolee