Re: [PATCH v2 0/5] scalar: enable built-in FSMonitor

From: Derrick Stolee <derrickstolee@github.com>
Date: Aug 17, 2022, 14:51 UTC
Message-ID: <69be513b-b6c3-3a92-6152-fddc835a6723@github.com>
In-Reply-To: <pull.1324.v2.git.1660694290.gitgitgadget@gmail.com>

On 8/16/2022 7:58 PM, Victoria Dye via GitGitGadget wrote:

> This series enables the built-in FSMonitor [1] on 'scalar'-registered
> repository enlistments. To avoid errors when unregistering an enlistment,
> the FSMonitor daemon is explicitly stopped during 'scalar unregister'.

I hadn't looked at this code in a while, so I poked around and asked some questions that might not even need answering.

Outside of a nit involving a test prereq, this version looks fine to me.

Thanks, -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.