Re: [PATCH 2/3] Move unsigned long option parsing out of pack-objects.c

From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: Jun 19, 2015, 11:03 UTC
Message-ID: <69265919.629073.1434711805415.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <1434705059-2793-3-git-send-email-charles@hashpling.org>

Charles Bailey <cbailey32@bloomberg.net> writes:

Show 11 quoted lines

> test_expect_success 'long options' '
> - test-parse-options --boolean --integer 1729 --boolean --string2=321 \
> - --verbose --verbose --no-dry-run --abbrev=10 --file fi.le\
> - --obsolete > output 2> output.err &&
> + test-parse-options --boolean --integer 1729 --unsigned-long 16k \
> + --boolean --string2=321 --verbose --verbose --no-dry-run \
> + --abbrev=10 --file fi.le --obsolete \
> + > output 2> output.err &&
> test_must_be_empty output.err &&
> test_cmp expect output
> '

It's trivial matter but the line:

> + > output 2> output.err &&

should be written:

> + >output 2>output.err &&

It was incorrectly written before but since you are modifying the line, it might be a good thing to change it now.

Rémi