Re: [PATCH 3/3] Add filter-objects command
- From
Charles Bailey <charles@hashpling.org>
- Date
- Jun 19, 2015, 11:04 UTC
- Message-ID
- <20150619110408.GA4513@hashpling.org>
- In-Reply-To
- <20150619105228.GR18226@serenity.lan>
On Fri, Jun 19, 2015 at 11:52:28AM +0100, John Keeping wrote:
Show 9 quoted lines
> On Fri, Jun 19, 2015 at 11:33:24AM +0100, Charles Bailey wrote:
> > So, yes, performance is definitely an issue and I could have called this
> > command "git magically-generate-all-object-for-scripts" but then, as it
> > was so easy to provide exactly the filtering that I was looking for in
> > the C code, I thought I would do that as well and then "filter-objects"
> > ("filter-all-objects"?) seemed like a better name.
>
> By analogy with "git filter-branch", I don't think "filter-objects" is a
> good name here. My preference would be "ls-objects".I like that because it emphasises why I wrote it, the very basic filtering is a nice additional feature.