git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase -i: fix reword when using a terminal editor

From
Björn Gustavsson <bgustavsson@gmail.com>
Date
Oct 16, 2009, 08:05 UTC
Message-ID
<6672d0160910160105t33ea0585r5c791d47d03f40a9@mail.gmail.com>
In-Reply-To
<1255674753-13949-1-git-send-email-bebarino@gmail.com>
2009/10/16 Stephen Boyd <bebarino@gmail.com>:
Show 14 quoted lines
> We don't want to use output() on git-commit --amend when rewording the
> commit message. This leads to confusion as the editor is run in a
> subshell with it's output saved away, leaving the user with a seemingly
> frozen terminal.
>
> Fix by removing the output part.
>
> Signed-off-by: Stephen Boyd <bebarino@gmail.com>
> ---
>
> On top of next.
>
> I think this is right, although I'm not really experienced in the rebase -i
> code
Thanks!

Yes, it seems right to me too after a more thorough reading of the existing rebase -i code. It seems that 'output' is only used for non-interactive commands.

I never noticed the problem because I use 'emacsclient' as my commit editor. I didn't think of testing with an editor that run in the terminal window.

/Björn
-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB
Previous: Stephen BoydNext: Junio C Hamano
Message 2 of 3 in “rebase -i: fix reword when using a terminal editor”
  1. rebase -i: fix reword when using a terminal editorStephen Boyd, Oct 16, 2009
  2. Björn GustavssonOct 16, 2009
  3. Junio C HamanoOct 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.