From: Björn Gustavsson <bgustavsson@gmail.com>
Date: Fri, 16 Oct 2009 08:05:39 GMT
Subject: Re: [PATCH] rebase -i: fix reword when using a terminal editor
Message-ID: <6672d0160910160105t33ea0585r5c791d47d03f40a9@mail.gmail.com>
In-Reply-To: <1255674753-13949-1-git-send-email-bebarino@gmail.com>

2009/10/16 Stephen Boyd <bebarino@gmail.com>:
> We don't want to use output() on git-commit --amend when rewording the
> commit message. This leads to confusion as the editor is run in a
> subshell with it's output saved away, leaving the user with a seemingly
> frozen terminal.
>
> Fix by removing the output part.
>
> Signed-off-by: Stephen Boyd <bebarino@gmail.com>
> ---
>
> On top of next.
>
> I think this is right, although I'm not really experienced in the rebase -i
> code

Thanks!

Yes, it seems right to me too after a more thorough reading of the
existing rebase -i code. It seems that 'output' is only used for
non-interactive commands.

I never noticed the problem because I use 'emacsclient' as my
commit editor. I didn't think of testing with an editor that run in
the terminal window.

/Björn
-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB