git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] rebase -i: fix reword when using a terminal editor

From
Stephen Boyd <bebarino@gmail.com>
Date
Oct 16, 2009, 06:32 UTC
Message-ID
<1255674753-13949-1-git-send-email-bebarino@gmail.com>

We don't want to use output() on git-commit --amend when rewording the commit message. This leads to confusion as the editor is run in a subshell with it's output saved away, leaving the user with a seemingly frozen terminal.

Fix by removing the output part.
Signed-off-by: Stephen Boyd <bebarino@gmail.com>
---
On top of next.

I think this is right, although I'm not really experienced in the rebase -i code

 git-rebase--interactive.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index a43ee22..a1879e3 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -346,7 +346,7 @@ do_next () {
 		mark_action_done
 		pick_one $sha1 ||
 			die_with_patch $sha1 "Could not apply $sha1... $rest"
-		output git commit --amend
+		git commit --amend
 		;;
 	edit|e)
 		comment_for_reflog edit
-- 
1.6.5.103.g6b436.dirty
Next: Björn Gustavsson
Message 1 of 3 in “rebase -i: fix reword when using a terminal editor”
  1. rebase -i: fix reword when using a terminal editorStephen Boyd, Oct 16, 2009
  2. Björn GustavssonOct 16, 2009
  3. Junio C HamanoOct 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.