Re: [PATCH 01/22] mailmap doc: create a new "gitmailmap(5)" man page

From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Jan 15, 2021, 02:38 UTC
Message-ID: <6612514d-051a-1e58-7ea1-c00428882f2d@gmail.com>
In-Reply-To: <xmqqk0sfxpd4.fsf@gitster.c.googlers.com>

Hi Junio

Le 2021-01-14 à 14:58, Junio C Hamano a écrit :

Show 14 quoted lines

> Philippe Blain <levraiphilippeblain@gmail.com> writes:
> 
>>> +SYNOPSIS
>>> +--------
>>> +$GIT_WORK_DIR/.mailmap
>>
>> This should be GIT_WORK_TREE, gitmodules(5) is wrong as GIT_WORK_DIR
>> does not exists (my series at [1] fixes this).
> 
> Well spotted.
> 
> Can you make the suggestion into a follow-up patch to the
> series to be applied on top?
>

I just sent [1] as a fixup! commit (is that what you meant?) I was not sure...) I feel it is cleaner for that commit to use the correct variable name from the start, hence the fixup.

Philippe.

[1] https://lore.kernel.org/git/87zh1b51xk.fsf@evledraar.gmail.com/T/#m9e8e8f5458db71153c2363acf4bff959df7d0f4c