Re: [PATCH 01/22] mailmap doc: create a new "gitmailmap(5)" man page

From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Jan 15, 2021, 03:36 UTC
Message-ID: <4c9123c0-ee35-11aa-04dc-8ffe79781507@gmail.com>
In-Reply-To: <xmqqft32vqe4.fsf@gitster.c.googlers.com>

Le 2021-01-14 à 22:18, Junio C Hamano a écrit :

Show 8 quoted lines

> Philippe Blain <levraiphilippeblain@gmail.com> writes:
> 
>> I was not sure...) I feel it is cleaner for that commit to use
>> the correct variable name from the start, hence the fixup.
> 
> The topic is already in 'next', and that is why I asked follow-up
> patches on top from people.  Otherwise I wouldn't have asked and
> instead just squashed these fixes in while the topic was in 'seen'.

OK, thanks for clarifying. I did not check the status of the series, probably because I saw it was from just 2 days ago so I did not think it would already be in next. I just sent a v2 with a proper commit message [2].

I'm still not sure I have should have sent it as a reply to the commit it's fixing (as I did), or to the last commit of the series, or to the cover letter, or as a new thread to the list... what's the etiquette around this ? (I'm still new to the email workflow, especially around multi-author series...)

Philippe.

[2] https://lore.kernel.org/git/20210115032826.51369-1-levraiphilippeblain@gmail.com/