Re: [PATCH v2 2/3] add -p: allow line selection to be inverted

From: Phillip Wood <phillip.wood@talktalk.net>
Date: Mar 8, 2018, 11:05 UTC
Message-ID: <6476d776-dbf7-09cf-1c65-e413798b9987@talktalk.net>
In-Reply-To: <xmqq371d3rjz.fsf@gitster-ct.c.googlers.com>

On 06/03/18 19:57, Junio C Hamano wrote:

Show 11 quoted lines

> Phillip Wood <phillip.wood@talktalk.net> writes:
> 
>> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>>
>> If the list of lines to be selected begins with '^' select all the
>> lines except the ones listed.
> 
> There is "# Input that begins with '-'; unchoose" in list_and_choose
> helper.  Does it make things inconsistent to use '^' for negation
> like this patch does with it?
>

Hmm yes, I think it probably does (I've just checked and git clean also uses '-' for de-selection). I think I'll remove support for open-ended ranges on the left side (it's not so hard to type '1-n' instead of '-n') and use a leading '-' for inversion. I'm tempted to keep supporting 'n-' to mean everything from 'n' to the last line though.

Best Wishes

Phillip