Re: [PATCH v2 0/3] add -p: select individual hunk lines
- From
- Igor Djordjevic <igor.d.djordjevic@gmail.com>
- Date
- Mar 6, 2018, 20:19 UTC
- Message-ID
- <64005dad-ec23-892c-4270-b01cae74f663@gmail.com>
- In-Reply-To
- <20180306101750.18794-1-phillip.wood@talktalk.net>
Hi Phillip,
On 06/03/2018 11:17, Phillip Wood wrote:
Show 20 quoted lines
> > From: Phillip Wood <phillip.wood@dunelm.org.uk> > > I've added some documentation to git-add.txt for the new selection > mode and cleaned up some style issues, otherwise these are unchanged > since v1. These patches build on top of the recount fixes in [1]. The > commit message for the first patch describes the motivation: > > "When I end up editing hunks it is almost always because I want to > stage a subset of the lines in the hunk. Doing this by editing the > hunk is inconvenient and error prone (especially so if the patch is > going to be reversed before being applied). Instead offer an option > for add -p to stage individual lines. When the user presses 'l' the > hunk is redrawn with labels by the insertions and deletions and they > are prompted to enter a list of the lines they wish to stage. Ranges > of lines may be specified using 'a-b' where either 'a' or 'b' may be > omitted to mean all lines from 'a' to the end of the hunk or all lines > from 1 upto and including 'b'." > > [1] https://public-inbox.org/git/xmqqbmg29x1n.fsf@gitster-ct.c.googlers.com/T/#m01d0f1af90f32b698e583b56f8e53b986bcec7c6
Nice, thank you :)
A small nitpick - I see you use phrasing like "select lines", where the other commands usually talk about "staging", instead, so "stage lines" might be more aligned with the existing text.
I`ll quickly go through the patches regarding this (not being of much help for the code itself at the moment, sorry!).
Regards, Buga