git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit-template: change a message to be more intuitive

From
Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
Date
Sep 13, 2017, 12:31 UTC
Message-ID
<624d873b-74af-b3e8-714c-8a439f4ee81f@gmail.com>
In-Reply-To
<20170913112013.sk7bqarq2ktrva67@sigill.intra.peff.net>
On Wednesday 13 September 2017 04:50 PM, Jeff King wrote:
Show 14 quoted lines
> I agree with both of your points. It is very clear to me as a native
> speaker, but I can see how it might not be for everyone.
>
> Interestingly, the change here:
>
>>> -	const char *explanation = _("Do not touch the line above.\nEverything below will be removed.");
>>> +	const char *explanation = _("Do not edit the line above.\nEverything below will be removed.");
> actually seems less clear to me. I think of "edit" as "modify". But
> obviously it also should not be removed. Perhaps
>
>    Do not modify or remove the line above.
>
> would be the most clear. Or perhaps it is overly verbose.
>

Seems to be a valid point. Further, it doesn't seem to be too verbose at least to me. So, I'll change the sentence and revert back to the one I use if someone finds it to be verbose.

--- Kaartic

Previous: Jeff KingNext: Kaartic Sivaraam
Message 4 of 15 in “commit-template: change a message to be more intuitive”
  1. commit-template: change a message to be more intuitiveKaartic Sivaraam, Sep 12, 2017
  2. Kevin DaudtSep 13, 2017
  3. Jeff KingSep 13, 2017
  4. Kaartic SivaraamSep 13, 2017
  5. commit-template: change a message to be more intuitiveKaartic Sivaraam, Sep 13, 2017
  6. commit-template: change a message to be more intuitiveKaartic Sivaraam, Sep 13, 2017
  7. Michael J GruberSep 14, 2017
  8. Kaartic SivaraamSep 14, 2017
  9. Jeff KingSep 14, 2017
  10. Junio C HamanoSep 15, 2017
  11. commit-template: change a message to be more intuitiveKaartic Sivaraam, Sep 15, 2017
  12. Michael J GruberSep 15, 2017
  13. Kaartic SivaraamSep 15, 2017
  14. Kaartic SivaraamSep 15, 2017
  15. Kaartic SivaraamSep 13, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.