Re: [PATCH v2] commit-template: change a message to be more intuitive

From: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
Date: Sep 14, 2017, 14:17 UTC
Message-ID: <2480c33b-7e44-5c7c-cd31-feae9168b9dc@gmail.com>
In-Reply-To: <862e71a1-2dee-4a20-d828-69a0547fa5ec@grubix.eu>

On Thursday 14 September 2017 01:06 PM, Michael J Gruber wrote:

Show 10 quoted lines

> Kaartic Sivaraam venit, vidit, dixit 13.09.2017 15:05:
>>   void wt_status_add_cut_line(FILE *fp)
>>   {
>> -	const char *explanation = _("Do not touch the line above.\nEverything below will be removed.");
>> +	const char *explanation = _("Do not modify or remove the line above.\nEverything below will be removed.");
> I don't want to complicate things. But now - due to the repeated usage
> of "remove" - these two sentences seem to be connected by an invisible
> "or else" ("will" vs. "would" not withstanding). i.e. "or else
> everything below will be removed, too", which is wrong. Before, they
> were separated more clearly.

At least I don't think they are connected by an invisible "or else" because they appear on different lines,

    # ------------------------ >8 ------------------------

    # Do not modify or remove the line above.

    # Everything below will be removed.

    diff --git a/hook-checks/hooks/applypatch-msg b/hook-checks/hooks/applypatch-msg

    new file mode 100755

    index 0000000..a5d7b84

    --- /dev/null

    +++ b/hook-checks/hooks/applypatch-msg

> Also, given all the translations that we have, it seems somewhat strange
> to try and foresee and workaround possible misunderstandings of commonly
> used English phrases.

I thought the translators wouldn't mind this! If they do, then it's better to drop this patch.

--- Kaartic