git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit-template: change a message to be more intuitive

From
Kevin Daudt <me@ikke.info>
Date
Sep 13, 2017, 10:29 UTC
Message-ID
<20170913102915.GA21499@alpha.vpn.ikke.info>
In-Reply-To
<20170912105536.6094-1-kaarticsivaraam91196@gmail.com>
On Tue, Sep 12, 2017 at 04:25:36PM +0530, Kaartic Sivaraam wrote:
> It's not possible to 'touch' the cut-line that is shown when the
> user requests a patch in his commit template.
> 

Touching something can also mean to disturb or change something, which is the meaning being used here, so it is not an incorrect use of the word.

> So, make the sentence more intuitive.

I can understand however that it might be not so clear for people with less fluency in English.

Show 24 quoted lines
> 
> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
> ---
>  Just a small tweak. May or may not be worth the patch.
> 
>  wt-status.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/wt-status.c b/wt-status.c
> index 77c27c511..1f54b1df2 100644
> --- a/wt-status.c
> +++ b/wt-status.c
> @@ -934,7 +934,7 @@ size_t wt_status_locate_end(const char *s, size_t len)
>  
>  void wt_status_add_cut_line(FILE *fp)
>  {
> -	const char *explanation = _("Do not touch the line above.\nEverything below will be removed.");
> +	const char *explanation = _("Do not edit the line above.\nEverything below will be removed.");
>  	struct strbuf buf = STRBUF_INIT;
>  
>  	fprintf(fp, "%c %s", comment_line_char, cut_line);
> -- 
> 2.14.1.1006.g90ad9a07c
> 
Previous: Kaartic SivaraamNext: Jeff King
Message 2 of 15 in “commit-template: change a message to be more intuitive”
  1. commit-template: change a message to be more intuitiveKaartic Sivaraam, Sep 12, 2017
  2. Kevin DaudtSep 13, 2017
  3. Jeff KingSep 13, 2017
  4. Kaartic SivaraamSep 13, 2017
  5. commit-template: change a message to be more intuitiveKaartic Sivaraam, Sep 13, 2017
  6. commit-template: change a message to be more intuitiveKaartic Sivaraam, Sep 13, 2017
  7. Michael J GruberSep 14, 2017
  8. Kaartic SivaraamSep 14, 2017
  9. Jeff KingSep 14, 2017
  10. Junio C HamanoSep 15, 2017
  11. commit-template: change a message to be more intuitiveKaartic Sivaraam, Sep 15, 2017
  12. Michael J GruberSep 15, 2017
  13. Kaartic SivaraamSep 15, 2017
  14. Kaartic SivaraamSep 15, 2017
  15. Kaartic SivaraamSep 13, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.