Re: [PATCH v2 00/13] push: revamp push.default

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jun 2, 2021, 04:05 UTC
Message-ID: <60b7036e8eaf1_511920821@natae.notmuch>
In-Reply-To: <xmqqr1hlqd5v.fsf@gitster.g>

Junio C Hamano wrote:

Show 10 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
> > The end result is almost identical to v1, only the way we get there
> > changes (plus there's an extra cosmetic break).
> 
> Good.  The endpoint matches exactly to what was queued, with the
> SQUASH??? fix for the "break" thing, which is necessary to make
> "make sparse" happy (so it is not just "cosmetic").
> 
> IOW, this series allows us to drop the following.

Indeed.

Show 10 quoted lines

> commit c1964311c404afaadffd57d14d769a4051281c2b
> Author: Junio C Hamano <gitster@pobox.com>
> Date:   Mon May 31 12:41:06 2021 +0900
> 
>     SQUASH??? fix compilation breakage
>     
>     make sparse found these:
>     
>     builtin/push.c:221:9: error: Expected ; at end of statement
>     builtin/push.c:221:9: error: got }

Is it really a "compilation breakage"?

Documentation/SubmittingPatches doesn't mention sparse. I do remember setting up sparse when I worked with Linux in the past, but it's not precisely a standard thing. At least in Arch Linux it's not even part of the main packages [1].

Cheers.

[1] https://aur.archlinux.org/packages/sparse/

-- 
Felipe Contreras