git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/5] doc: asciidoc cleanups

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 27, 2021, 17:35 UTC
Message-ID
<60afd868b68ae_2653020870@natae.notmuch>
In-Reply-To
<YK/SZGTWd/tfSWeP@coredump.intra.peff.net>
Jeff King wrote:
Show 15 quoted lines
> > > The "comments-by" sub-thread looked unproductive to me, so I mostly
> > > skipped it. ;) But as the person whose name was in the trailer, I will
> > > say that I do not care either way if it is included. It did not seem to
> > > add anything to me. Some trailers are good for pointing later readers to
> > > folks who may be able to help understand or debug an old commit. Some
> > > are good for just giving credit to people who helped. "Comments-by"
> > > didn't really seem to do either to me (and I don't feel like I
> > > contributed much worthy of credit anyway).
> > 
> > But you did provide comments, and those comments resulted in changes, so
> > the comments-by line is accurate. And for what it's worth that commit
> > trailer line has been used 3 times already, which places it in the 3rd
> > top decile.
> 
> I didn't say it was inaccurate. I just think it is not useful.

I understood. I'm not saying the tag must be there because it's useful (I agree it's usefulness is marginal at best), I'm saying including it does not hurt.

-- 
Felipe Contreras
Previous: Jeff KingNext: Junio C Hamano
Message 19 of 21 in “doc: asciidoc cleanups”
  1. 0/5 doc: asciidoc cleanupsFelipe Contreras, May 21, 2021
  2. 1/5 doc: refactor common asciidoc dependenciesFelipe Contreras, May 21, 2021
  3. 2/5 doc: improve asciidoc dependenciesFelipe Contreras, May 21, 2021
  4. 3/5 doc: remove unnecessary rm instancesFelipe Contreras, May 21, 2021
  5. Junio C HamanoMay 24, 2021
  6. Felipe ContrerasMay 24, 2021
  7. Felipe ContrerasMay 24, 2021
  8. Junio C HamanoMay 25, 2021
  9. Felipe ContrerasMay 25, 2021
  10. Junio C HamanoMay 25, 2021
  11. Felipe ContrerasMay 25, 2021
  12. Felipe ContrerasMay 26, 2021
  13. 4/5 doc: simplify Makefile using .DELETE_ON_ERRORFelipe Contreras, May 21, 2021
  14. 5/5 doc: avoid using rm directlyFelipe Contreras, May 21, 2021
  15. Junio C HamanoMay 24, 2021
  16. Jeff KingMay 27, 2021
  17. Felipe ContrerasMay 27, 2021
  18. Jeff KingMay 27, 2021
  19. Felipe ContrerasMay 27, 2021
  20. Junio C HamanoMay 28, 2021
  21. Felipe ContrerasMay 28, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.