Re: [PATCH v3 3/5] doc: remove unnecessary rm instances

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 25, 2021, 06:54 UTC
Message-ID: <60ac9f332eeec_225d820832@natae.notmuch>
In-Reply-To: <xmqqwnrnh626.fsf@gitster.g>

Junio C Hamano wrote:

Show 19 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
> > I happen to have at hand a script that ranks the most common trailer
> > lines:
> >
> >  * acked-by: 25% (1945)
> >
> > Doesn't apply.
> >
> >  * reviewed-by: 22% (1729)
> >
> > This does apply, but I'm not confident Jeff would like me to add that.
> >
> >  * helped-by: 17% (1336)
> 
> I actually think people use this one to say "person X gave a
> valuable input in the review discussion", which is exactly the case
> here, and that was why I wondered you needed to invent a completely
> new one.

I think the opposite: "helped-by" encompasses virtually anything. A person that reviews, reports, mentors, suggests, tests, provides a patch, contributes, and co-authors... is helping.

The question is *how* he helped in this particular patch... By providing comments.

-- 
Felipe Contreras