git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 5/5] doc: avoid using rm directly

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 21, 2021, 22:29 UTC
Message-ID
<20210521222941.525901-6-felipe.contreras@gmail.com>
In-Reply-To
<20210521222941.525901-1-felipe.contreras@gmail.com>
That's what we have $(RM) for.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 Documentation/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/Makefile b/Documentation/Makefile
index eaff97dcb8..f5605b7767 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -398,7 +398,7 @@ git.info: user-manual.texi
 user-manual.texi: user-manual.xml
 	$(QUIET_DB2TEXI)$(DOCBOOK2X_TEXI) user-manual.xml --encoding=UTF-8 --to-stdout >$@+ && \
 	$(PERL_PATH) fix-texi.perl <$@+ >$@ && \
-	rm $@+
+	$(RM) $@+
 
 user-manual.pdf: user-manual.xml
 	$(QUIET_DBLATEX)$(DBLATEX) -o $@ $(DBLATEX_COMMON) $<
@@ -407,9 +407,9 @@ gitman.texi: $(MAN_XML) cat-texi.perl texi.xsl
 	$(QUIET_DB2TEXI) \
 	($(foreach xml,$(sort $(MAN_XML)),xsltproc -o $(xml)+ texi.xsl $(xml) && \
 		$(DOCBOOK2X_TEXI) --encoding=UTF-8 --to-stdout $(xml)+ && \
-		rm $(xml)+ &&) true) > $@+ && \
+		$(RM) $(xml)+ &&) true) > $@+ && \
 	$(PERL_PATH) cat-texi.perl $@ <$@+ >$@ && \
-	rm $@+
+	$(RM) $@+
 
 gitman.info: gitman.texi
 	$(QUIET_MAKEINFO)$(MAKEINFO) --no-split --no-validate $*.texi
-- 
2.32.0.rc0
Previous: Felipe ContrerasNext: Junio C Hamano
Message 14 of 21 in “doc: asciidoc cleanups”
  1. 0/5 doc: asciidoc cleanupsFelipe Contreras, May 21, 2021
  2. 1/5 doc: refactor common asciidoc dependenciesFelipe Contreras, May 21, 2021
  3. 2/5 doc: improve asciidoc dependenciesFelipe Contreras, May 21, 2021
  4. 3/5 doc: remove unnecessary rm instancesFelipe Contreras, May 21, 2021
  5. Junio C HamanoMay 24, 2021
  6. Felipe ContrerasMay 24, 2021
  7. Felipe ContrerasMay 24, 2021
  8. Junio C HamanoMay 25, 2021
  9. Felipe ContrerasMay 25, 2021
  10. Junio C HamanoMay 25, 2021
  11. Felipe ContrerasMay 25, 2021
  12. Felipe ContrerasMay 26, 2021
  13. 4/5 doc: simplify Makefile using .DELETE_ON_ERRORFelipe Contreras, May 21, 2021
  14. 5/5 doc: avoid using rm directlyFelipe Contreras, May 21, 2021
  15. Junio C HamanoMay 24, 2021
  16. Jeff KingMay 27, 2021
  17. Felipe ContrerasMay 27, 2021
  18. Jeff KingMay 27, 2021
  19. Felipe ContrerasMay 27, 2021
  20. Junio C HamanoMay 28, 2021
  21. Felipe ContrerasMay 28, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.