git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/5] gitweb: Fix error in git_patchest_body for file creation/deletion patch

From
LTLuben Tuikov <ltuikov@yahoo.com>
Date
Jan 8, 2007, 03:53 UTC
Message-ID
<601528.75484.qm@web31805.mail.mud.yahoo.com>
In-Reply-To
<1168134751748-git-send-email-jnareb@gmail.com>
--- Jakub Narebski <jnareb@gmail.com> wrote:
> $from_id, $to_id variables should be local per PATCH.

There. You've already refactored the logic, now pull it into a separate function.

BTW, I'll try the patches (unless Junio commits them to "next" first) Monday sometime.

    Luben
Previous: Jakub NarebskiNext: Jakub Narebski
Message 13 of 17 in “Bugs in gitweb”
  1. Luben TuikovJan 5, 2007
  2. 0/5 gitweb: git_patchset_body fixesJakub Narebski, Jan 7, 2007
  3. Luben TuikovJan 8, 2007
  4. Jakub NarebskiJan 8, 2007
  5. Luben TuikovJan 9, 2007
  6. Jakub NarebskiJan 9, 2007
  7. Jakub NarebskiJan 9, 2007
  8. Luben TuikovJan 9, 2007
  9. gitweb: Fix git_patchset_body not closing <div class="patch">Jakub Narebski, Jan 9, 2007
  10. Luben TuikovJan 9, 2007
  11. Luben TuikovJan 9, 2007
  12. 1/5 gitweb: Fix error in git_patchest_body for file creation/deletion patchJakub Narebski, Jan 7, 2007
  13. Luben TuikovJan 8, 2007
  14. 2/5 gitweb: Fix error in "rename to"/"copy to" git diff header outputJakub Narebski, Jan 7, 2007
  15. 3/5 gitweb: Fix errors in git_patchset_body for empty patchesJakub Narebski, Jan 7, 2007
  16. 4/5 Revert "gitweb: There can be empty patches (in git_patchset_body)"Jakub Narebski, Jan 7, 2007
  17. 5/5 gitweb: Fix split patches output (e.g. file to symlink)Jakub Narebski, Jan 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.