git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] gitweb: git_patchset_body fixes

From
LTLuben Tuikov <ltuikov@yahoo.com>
Date
Jan 9, 2007, 04:25 UTC
Message-ID
<351088.61033.qm@web31801.mail.mud.yahoo.com>
In-Reply-To
<1168134747394-git-send-email-jnareb@gmail.com>

Ok, I see that Junio has committed the fixes to "next" -- thanks! That saved me time having to manually apply them.

Now, the results are that I see the same bug.

gitweb and gitcore as reported by the xml header is 1.4.4.4.g7c5d, which is "next" as of a few minutes ago, merged over twice into my branchA and branchB (names changed).

The commit that fails looks is the attachment with names and contents changed to protect the innocent.

The complaint Firefox 2.0.0.1 says is the err.txt file attached.

    Luben
XML Parsing Error: mismatched tag. Expected: </div>.
Location: http://lion.vitesse.com/git/?p=vhal.git;a=commitdiff;h=b4e81df5f58bc24bb690b5b3687fd36180e071b8;hp=bd5f8325508ee5151d84d65f50b72fd7f3ecc77a
Line Number 95, Column 3:

</body> --^

$ git-diff-tree -r --no-commit-id --patch-with-raw --full-index b4e81df5f58bc24bb690b5b3687fd36180e071b8 > /tmp/diff.txt

:100644 100644 a4bf8891fc1153946b2d1531fdfe09f53a532c65 28929eb48708d0bc33d4c80c4349e753332ea4e1 M fileA :000000 100644 0000000000000000000000000000000000000000 36dec28bfc5ec04cff264fd1b7c4b47ab7bad3e3 A fileB :100644 000000 36dec28bfc5ec04cff264fd1b7c4b47ab7bad3e3 0000000000000000000000000000000000000000 D fileC

diff --git a/fileA b/fileA
index a4bf8891fc1153946b2d1531fdfe09f53a532c65..28929eb48708d0bc33d4c80c4349e753332ea4e1 100644
--- a/fileA
+++ b/fileA
@@ -1,6 +1,6 @@

... one line change ...

diff --git a/fileB b/fileB
new file mode 100644
index 0000000000000000000000000000000000000000..36dec28bfc5ec04cff264fd1b7c4b47ab7bad3e3
--- /dev/null
+++ b/fileB
@@ -0,0 +1,89 @@

... it is obvious what happened here ...

diff --git a/fileC b/fileC
deleted file mode 100644
index 36dec28bfc5ec04cff264fd1b7c4b47ab7bad3e3..0000000000000000000000000000000000000000
--- a/fileC
+++ /dev/null
@@ -1,89 +0,0 @@

... again it is obvious what happened here ...
Previous: Jakub NarebskiNext: Jakub Narebski
Message 5 of 17 in “Bugs in gitweb”
  1. Luben TuikovJan 5, 2007
  2. 0/5 gitweb: git_patchset_body fixesJakub Narebski, Jan 7, 2007
  3. Luben TuikovJan 8, 2007
  4. Jakub NarebskiJan 8, 2007
  5. Luben TuikovJan 9, 2007
  6. Jakub NarebskiJan 9, 2007
  7. Jakub NarebskiJan 9, 2007
  8. Luben TuikovJan 9, 2007
  9. gitweb: Fix git_patchset_body not closing <div class="patch">Jakub Narebski, Jan 9, 2007
  10. Luben TuikovJan 9, 2007
  11. Luben TuikovJan 9, 2007
  12. 1/5 gitweb: Fix error in git_patchest_body for file creation/deletion patchJakub Narebski, Jan 7, 2007
  13. Luben TuikovJan 8, 2007
  14. 2/5 gitweb: Fix error in "rename to"/"copy to" git diff header outputJakub Narebski, Jan 7, 2007
  15. 3/5 gitweb: Fix errors in git_patchset_body for empty patchesJakub Narebski, Jan 7, 2007
  16. 4/5 Revert "gitweb: There can be empty patches (in git_patchset_body)"Jakub Narebski, Jan 7, 2007
  17. 5/5 gitweb: Fix split patches output (e.g. file to symlink)Jakub Narebski, Jan 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.