git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Bugs in gitweb

From
LTLuben Tuikov <ltuikov@yahoo.com>
Date
Jan 5, 2007, 01:29 UTC
Message-ID
<100171.86639.qm@web31814.mail.mud.yahoo.com>

gitweb has two bugs in git_patchset_body (now you know who you are without data-mining with git-blame).

The first bug is a missing "</div>" on commitdiff. Saw this one a couple of days ago, but was swamped and had no time to post.

The second bug is displaying a renamed file with the same name as the one of the preceding "patch". Saw this one today when I pulled.

To exhibit these, you need to "commitdiff" a commit which has at least one rename and at least one regular diff preceding the rename.

Can the guilty parties (you know who you are) please fix this.

"And while at it" can you please actually *do* "refactor" git_patchset_body *into smaller functions each one doing a single particular task*.

It is sad to see git_patchset_body in such despicable state all the while seeing words like "refactor" in the commit logs of that function.

git_patchset_body is grossly overloaded for what it is supposed to do to, and being one single huge blob, it is hard to maintain.

Thanks,
    Luben
Next: Jakub Narebski
Message 1 of 17 in “Bugs in gitweb”
  1. Luben TuikovJan 5, 2007
  2. 0/5 gitweb: git_patchset_body fixesJakub Narebski, Jan 7, 2007
  3. Luben TuikovJan 8, 2007
  4. Jakub NarebskiJan 8, 2007
  5. Luben TuikovJan 9, 2007
  6. Jakub NarebskiJan 9, 2007
  7. Jakub NarebskiJan 9, 2007
  8. Luben TuikovJan 9, 2007
  9. gitweb: Fix git_patchset_body not closing <div class="patch">Jakub Narebski, Jan 9, 2007
  10. Luben TuikovJan 9, 2007
  11. Luben TuikovJan 9, 2007
  12. 1/5 gitweb: Fix error in git_patchest_body for file creation/deletion patchJakub Narebski, Jan 7, 2007
  13. Luben TuikovJan 8, 2007
  14. 2/5 gitweb: Fix error in "rename to"/"copy to" git diff header outputJakub Narebski, Jan 7, 2007
  15. 3/5 gitweb: Fix errors in git_patchset_body for empty patchesJakub Narebski, Jan 7, 2007
  16. 4/5 Revert "gitweb: There can be empty patches (in git_patchset_body)"Jakub Narebski, Jan 7, 2007
  17. 5/5 gitweb: Fix split patches output (e.g. file to symlink)Jakub Narebski, Jan 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.