Re: [PATCH v7 3/5] pull: get rid of unnecessary global variable

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Dec 15, 2020, 02:55 UTC
Message-ID: <5fd825898271c_d7c482086d@natae.notmuch>
In-Reply-To: <xmqqv9d49dxk.fsf@gitster.c.googlers.com>

Junio C Hamano wrote:

Show 18 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
> > Junio C Hamano wrote:
> >> It is easy enough to do,
> >
> > Yes.
> >
> >> gives a more descriptive name to the variable,
> >
> > I disagree.
> >
> >> and there is no reason to make the code deliberately worse by ignoring
> >> improvement offered on the list.
> >
> > I doubt any person contributing to the mailing is making the code
> > deliberately worse.
> 
> Oh, I doubt that you do so with what you send out.  I am saying that
> you do so by not taking improvements.

I do take improvements, when I agree they are improvements. In fact I did take virtually all of Elijah Newren's improvements.

> It wastes reviewers' time, raises noise ratio in the list traffic, and
> demotivates readers.

Are you saying I must always agree with you, or I waste your time?

In my view no one is infallible, just because X person says Y is an improvement that doesn't necessarily mean it actually is.

I thought this was a collaborative process where you are supposed to listen to my feedback to your suggestions too.

But I guess I shall take your "suggestions" as *orders*.

-- 
Felipe Contreras