git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-grep Bus Error

From
Brian Gernhardt <brian@gernhardtsoftware.com>
Date
Mar 9, 2009, 01:19 UTC
Message-ID
<5A3896E0-E4F2-4AD1-8106-1E2CC82D18F5@gernhardtsoftware.com>
In-Reply-To
<7vtz63ijoz.fsf@gitster.siamese.dyndns.org>
On Mar 8, 2009, at 9:11 PM, Junio C Hamano wrote:
Show 10 quoted lines
> Sam Hocevar <sam@zoy.org> writes:
>
>>   rm_so and rm_eo are ints on Linux but off_t's on Darwin, hence
>> probably int64_t's here. You should cast the arguments.
>
> That is a very good point.  In fact, "git grep -n -e 'printf.*%\.\*s'"
> reveals that many existing call sites to this form casts the precision
> argument explicitly to "int".
>
> Brian, would this patch help?

Yes, except that the code also depends on printf("%.*s", 0, str) working properly. I just sent a patch which checks for zero width and performs the casts.

~~ Brian
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 9 in “git-grep Bus Error”
  1. Brian GernhardtMar 8, 2009
  2. Sam HocevarMar 8, 2009
  3. Brian GernhardtMar 9, 2009
  4. Junio C HamanoMar 9, 2009
  5. Junio C HamanoMar 9, 2009
  6. Brian GernhardtMar 9, 2009
  7. grep: cast printf %.*s "precision" argument explicitly to intJunio C Hamano, Mar 9, 2009
  8. Brian GernhardtMar 9, 2009
  9. Junio C HamanoMar 9, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.