Re: git-grep Bus Error
- From
Brian Gernhardt <brian@gernhardtsoftware.com>
- Date
- Mar 9, 2009, 01:48 UTC
- Message-ID
- <981DB931-6FE4-484E-B101-EFCCAA5E2973@gernhardtsoftware.com>
- In-Reply-To
- <7vtz63ijoz.fsf@gitster.siamese.dyndns.org>
On Mar 8, 2009, at 9:11 PM, Junio C Hamano wrote:
Show 22 quoted lines
> Brian, would this patch help?
>
> grep.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/grep.c b/grep.c
> index cace1c8..dcdbd5e 100644
> --- a/grep.c
> +++ b/grep.c
> @@ -490,9 +490,9 @@ static void show_line(struct grep_opt *opt, char
> *bol, char *eol,
> *eol = '\0';
> while (next_match(opt, bol, eol, ctx, &match, eflags)) {
> printf("%.*s%s%.*s%s",
> - match.rm_so, bol,
> + (int) match.rm_so, bol,
> opt->color_match,
> - match.rm_eo - match.rm_so, bol + match.rm_so,
> + (int)(match.rm_eo - match.rm_so), bol + match.rm_so,
> GIT_COLOR_RESET);
> bol += match.rm_eo;
> rest -= match.rm_eo;Apparently so. Despite the fact that match.rm_so is 0 at times, "%.*s" works properly so the other half of the patch isn't needed. Odd.
~~ B