From: Brian Gernhardt <brian@gernhardtsoftware.com>
Date: Mon, 09 Mar 2009 01:19:35 GMT
Subject: Re: git-grep Bus Error
Message-ID: <5A3896E0-E4F2-4AD1-8106-1E2CC82D18F5@gernhardtsoftware.com>
In-Reply-To: <7vtz63ijoz.fsf@gitster.siamese.dyndns.org>


On Mar 8, 2009, at 9:11 PM, Junio C Hamano wrote:

> Sam Hocevar <sam@zoy.org> writes:
>
>>   rm_so and rm_eo are ints on Linux but off_t's on Darwin, hence
>> probably int64_t's here. You should cast the arguments.
>
> That is a very good point.  In fact, "git grep -n -e 'printf.*%\.\*s'"
> reveals that many existing call sites to this form casts the precision
> argument explicitly to "int".
>
> Brian, would this patch help?

Yes, except that the code also depends on printf("%.*s", 0, str)  
working properly.  I just sent a patch which checks for zero width and  
performs the casts.

~~ Brian