Re: [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings
Show 9 quoted lines
> On Thu, Oct 02, 2008 at 02:08:47AM +0200, David Soria Parra wrote:
>
>> Solaris systems use the old styled iconv(3) call and therefore
>> the OLD_ICONV variable should be set. Otherwise we get annoying compile
>> warnings.
>
> Acked-by: Jeff King <peff@peff.net>
>
> I set OLD_ICONV on my Solaris build.
>
> Do you also unset NEEDS_LIBICONV (and which version of Solaris are you
> running)?
I do not set NEEDS_LIBICONV.
-brandon