From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Thu, 02 Oct 2008 15:25:16 GMT
Subject: Re: [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings
Message-ID: <5A1KxlhmUIHe8iXPxnXYuNXsq0Yjlbwkz2eBin3z7ELuL9nK-4tSpw@cipher.nrlssc.navy.mil>
In-Reply-To: <20081002010816.GA27415@coredump.intra.peff.net>

Jeff King wrote:
> On Thu, Oct 02, 2008 at 02:08:47AM +0200, David Soria Parra wrote:
> 
>> Solaris systems use the old styled iconv(3) call and therefore
>> the OLD_ICONV variable should be set. Otherwise we get annoying compile
>> warnings.
> 
> Acked-by: Jeff King <peff@peff.net>
> 
> I set OLD_ICONV on my Solaris build.

Ditto here on 7.

> 
> Do you also unset NEEDS_LIBICONV (and which version of Solaris are you
> running)?

I do not set NEEDS_LIBICONV.

-brandon