git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Solaris: Use OLD_ICONV to avoid compile warnings

From
David Soria Parra <sn_@gmx.net>
Date
Oct 2, 2008, 00:08 UTC
Message-ID
<1222906127-16900-1-git-send-email-sn_@gmx.net>
From: David Soria Parra <dsp@php.net>

Solaris systems use the old styled iconv(3) call and therefore the OLD_ICONV variable should be set. Otherwise we get annoying compile warnings.

Signed-off-by: David Soria Parra <dsp@php.net>
---
 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index 7db2ccc..3abbb4e 100644
--- a/Makefile
+++ b/Makefile
@@ -649,6 +649,7 @@ ifeq ($(uname_S),SunOS)
 	NO_MEMMEM = YesPlease
 	NO_HSTRERROR = YesPlease
 	NO_MKDTEMP = YesPlease
+	OLD_ICONV = UnfortunatelyYes
 	ifeq ($(uname_R),5.8)
 		NEEDS_LIBICONV = YesPlease
 		NO_UNSETENV = YesPlease
-- 
1.6.0.2.569.g798a2a
Next: Jeff King
Message 1 of 4 in “Solaris: Use OLD_ICONV to avoid compile warnings”
  1. Solaris: Use OLD_ICONV to avoid compile warningsDavid Soria Parra, Oct 2, 2008
  2. Jeff KingOct 2, 2008
  3. David Soria ParraOct 2, 2008
  4. Brandon CaseyOct 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.