Re: [PATCH v2 2/2] format-patch: learn --[no-]range-diff-notes
On Sun, Sep 27, 2026, at 14:50, Junio C Hamano wrote:
Show 19 quoted lines
> kristofferhaugsbakk@fastmail.com writes:
>
>> diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh
>> index ef92704de39..640c5dec52e 100755
>> --- a/t/t3206-range-diff.sh
>> +++ b/t/t3206-range-diff.sh
>> ...
>> +# The '--range-diff-notes' has no effect but is allowed
>> +test_expect_success 'format-patch --range-diff-notes=not-a-note (no --range-diff)' '
>> + test_when_finished "rm -f 000?-*" &&
>> + git format-patch --range-diff-notes=not-a-note --cover-letter \
>> + main..unmodified &&
>> + test_when_finished "rm -f 000?-*" &&
>> + test_file_not_empty 0000-cover-letter* &&
>> + test_grep ! "^Range-diff:" 0000-cover-letter* &&
>> + test_grep ! "## Notes " 0000-cover-letter*
>> +'
>
> The second test_when_finished is redundant, I suspect.
Oh yeah. If there is no Range-diff then
there won't be a notes section. I'll fix that
in the next version.
Show 5 quoted lines
>
> Other than this minor nit, I didn't see anything questionable in
> this step.
>
> Thanks.
Kristoffer Haugsbakk <code@khaugsbakk.name>