Re: [PATCH v2 2/2] format-patch: learn --[no-]range-diff-notes

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 27, 2026, 12:50 UTC
Message-ID: <xmqq33uusvst.fsf@gitster.g>
In-Reply-To: <V2_format-patch_learn_--range-diff-notes.cdd@msgid.xyz>

kristofferhaugsbakk@fastmail.com writes:

Show 15 quoted lines

> diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh
> index ef92704de39..640c5dec52e 100755
> --- a/t/t3206-range-diff.sh
> +++ b/t/t3206-range-diff.sh
> ...
> +# The '--range-diff-notes' has no effect but is allowed
> +test_expect_success 'format-patch --range-diff-notes=not-a-note (no --range-diff)' '
> +	test_when_finished "rm -f 000?-*" &&
> +	git format-patch --range-diff-notes=not-a-note --cover-letter \
> +		main..unmodified &&
> +	test_when_finished "rm -f 000?-*" &&
> +	test_file_not_empty 0000-cover-letter* &&
> +	test_grep ! "^Range-diff:" 0000-cover-letter* &&
> +	test_grep ! "## Notes " 0000-cover-letter*
> +'

The second test_when_finished is redundant, I suspect.

Other than this minor nit, I didn't see anything questionable in this step.

Thanks.