Re: [PATCH 12/13] dir_iterator: new API for iterating over a directory tree
On 06/01/2016 02:12 AM, David Turner wrote:
Show 11 quoted lines
> On Mon, 2016-05-30 at 09:55 +0200, Michael Haggerty wrote:
>> +struct dir_iterator_level {
>> + int initialized;
>> +
>> + DIR *dir;
>> +
>> + /*
>> + * The length of the directory part of refname at this level
>
>
> "refname"? Isn't this was for directories?Show 5 quoted lines
>> + if (lstat(iter->base.path.buf, &iter
> ->base.st) < 0)
>> + continue; /* silently skip */
>
> Should we warn on non-ENOENT errors here?
Good idea. I'll add that.
Show 5 quoted lines
>> +/*
>> + * End the iteration before it has been exhausted. Free the
>> reference
>
> s/reference/directory/
Michael Haggerty <mhagger@alum.mit.edu>