From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Fri, 03 Jun 2016 11:57:49 GMT
Subject: Re: [PATCH 12/13] dir_iterator: new API for iterating over a directory tree
Message-ID: <575170BD.2050604@alum.mit.edu>
In-Reply-To: <1464739954.3988.6.camel@twopensource.com>

On 06/01/2016 02:12 AM, David Turner wrote:
> On Mon, 2016-05-30 at 09:55 +0200, Michael Haggerty wrote:
>> +struct dir_iterator_level {
>> +	int initialized;
>> +
>> +	DIR *dir;
>> +
>> +	/*
>> +	 * The length of the directory part of refname at this level
> 
> 
> "refname"? Isn't this was for directories?

Thanks.

>> +			if (lstat(iter->base.path.buf, &iter
> ->base.st) < 0)
>> +				continue; /* silently skip */
> 
> Should we warn on non-ENOENT errors here?

Good idea. I'll add that.

>> +/*
>> + * End the iteration before it has been exhausted. Free the
>> reference
> 
> s/reference/directory/

Thanks. Will fix.

Michael