Re: [PATCH 09/13] refs: introduce an iterator interface

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: May 31, 2016, 01:16 UTC
Message-ID: <574CE601.3010701@alum.mit.edu>
In-Reply-To: <574C70EF.5070705@ramsayjones.plus.com>

On 05/30/2016 06:57 PM, Ramsay Jones wrote:

Show 26 quoted lines

> 
> 
> On 30/05/16 16:22, Ramsay Jones wrote:
>>
>>
>> On 30/05/16 08:55, Michael Haggerty wrote:
>> [snip]
>>
>>>  /* Reference is a symbolic reference. */
>>> diff --git a/refs/files-backend.c b/refs/files-backend.c
>>> index 8ab4d5f..dbf1587 100644
>>> --- a/refs/files-backend.c
>>> +++ b/refs/files-backend.c
>>> [...]
>>> +			sort_ref_dir(dir);
>>
>> do you need to sort here ...
>>> [...]
>>> +			sort_ref_dir(level->dir);
>>
>> ... given that you sort here?
> 
> I had intended to say 'or vice versa' here. When I wrote this, I had not
> finished reading this patch (let alone the series). Now, I suspect that
> you can simply drop this 'sort_ref_dir()' call site. Unless I've misread
> the code, of course! ;-)

Yes, you are right. Thanks for catching this! I'll fix it in v2.

Michael