[PATCH] tag.c: remove extern keyword from function definition

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Apr 20, 2016, 15:34 UTC
Message-ID: <5717A181.1000603@ramsayjones.plus.com>

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Santiago,

If you need to re-roll your 'st/verify-tag' branch, could you please squash this into the relevant patch (commit c5213b40, "verify-tag: move tag verification code to tag.c", 19-04-2016).

Although not actually an error, it is very unusual for an extern keyword to be used on a function definition (it seems to be getting quite unusual on a function declaration these days!), which causes sparse to issue a warning.

Thanks!

ATB, Ramsay Jones

 tag.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tag.c b/tag.c
index ace619a..93c6ae6 100644
--- a/tag.c
+++ b/tag.c
@@ -30,7 +30,7 @@ static int run_gpg_verify(const char *buf, unsigned long size, unsigned flags)
 	return ret;
 }
 
-extern int gpg_verify_tag(const unsigned char *sha1,
+int gpg_verify_tag(const unsigned char *sha1,
 		const char *name_to_report, unsigned flags)
 {
 	enum object_type type;

-- 
2.8.0