git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tag.c: remove extern keyword from function definition

From
Santiago Torres <santiago@nyu.edu>
Date
Apr 20, 2016, 15:39 UTC
Message-ID
<20160420153928.GA1314@LykOS>
In-Reply-To
<5717A181.1000603@ramsayjones.plus.com>
On Wed, Apr 20, 2016 at 04:34:25PM +0100, Ramsay Jones wrote:
Show 14 quoted lines
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Santiago,
> 
> If you need to re-roll your 'st/verify-tag' branch, could you
> please squash this into the relevant patch (commit c5213b40,
> "verify-tag: move tag verification code to tag.c", 19-04-2016).
> 
> Although not actually an error, it is very unusual for an extern
> keyword to be used on a function definition (it seems to be getting
> quite unusual on a function declaration these days!), which causes
> sparse to issue a warning.

Oh sure! I'm waiting to see if there are more reviews regarding this and I'll re-roll. It's defintely unecessary to have the extern keyword there.

Thanks for pointing it out!
-Santiago.
Previous: Ramsay Jones
Message 2 of 2 in “tag.c: remove extern keyword from function definition”
  1. tag.c: remove extern keyword from function definitionRamsay Jones, Apr 20, 2016
  2. Santiago TorresApr 20, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.