git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Add the tag.gpgsign option to sign all created tags

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Mar 20, 2016, 16:38 UTC
Message-ID
<56EED20A.3000407@ramsayjones.plus.com>
In-Reply-To
<20160320150703.GB5139@spk-laptop>
On 20/03/16 15:07, Laurent Arnoud wrote:
> The `tag.gpgsign` config option allows to sign all
> commits automatically.
  ^^^^^^^
presumably you meant tags.
Show 37 quoted lines
> 
> Support `--no-sign` option to countermand configuration `tag.gpgsign`.
> 
> Signed-off-by: Laurent Arnoud <laurent@spkdev.net>
> Reviewed-by: Jeff King <peff@peff.net>
> ---
>  Documentation/config.txt  |  3 +++
>  Documentation/git-tag.txt |  4 ++++
>  builtin/tag.c             | 21 ++++++++++++++++-----
>  3 files changed, 23 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 2cd6bdd..076c68a 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -2729,6 +2729,9 @@ submodule.<name>.ignore::
>  	"--ignore-submodules" option. The 'git submodule' commands are not
>  	affected by this setting.
>  
> +tag.gpgSign::
> +	A boolean to specify whether all tags created should be GPG signed.
> +
>  tag.sort::
>  	This variable controls the sort ordering of tags when displayed by
>  	linkgit:git-tag[1]. Without the "--sort=<value>" option provided, the
> diff --git a/Documentation/git-tag.txt b/Documentation/git-tag.txt
> index abab481..757baa1 100644
> --- a/Documentation/git-tag.txt
> +++ b/Documentation/git-tag.txt
> @@ -64,6 +64,10 @@ OPTIONS
>  --sign::
>  	Make a GPG-signed tag, using the default e-mail address's key.
>  
> +--no-sign::
> +	Countermand `tag.gpgSign` configuration variable that is
> +	set to force each and every tag to be signed.
> +

I assume that, after setting tag.gpgsign in the config, this is the only way to get a lightweight tag. Maybe here, or above in config.txt, this could be stated more obviously? dunno.

[Also, don't we normally describe --[no]-sign options together?]

ATB, Ramsay Jones

Previous: Laurent ArnoudNext: Junio C Hamano
Message 7 of 22 in “Add the tag.gpgsign option to sign all created tags”
  1. Add the tag.gpgsign option to sign all created tagsLaurent Arnoud, Mar 19, 2016
  2. Jeff KingMar 20, 2016
  3. Laurent ArnoudMar 20, 2016
  4. Jeff KingMar 20, 2016
  5. Laurent ArnoudMar 20, 2016
  6. Add the tag.gpgsign option to sign all created tagsLaurent Arnoud, Mar 20, 2016
  7. Ramsay JonesMar 20, 2016
  8. Junio C HamanoMar 21, 2016
  9. Laurent ArnoudMar 21, 2016
  10. Junio C HamanoMar 21, 2016
  11. Laurent ArnoudMar 21, 2016
  12. Jeff KingMar 21, 2016
  13. Add the tag.gpgsign option to sign annotated tagsLaurent Arnoud, Mar 21, 2016
  14. Junio C HamanoMar 21, 2016
  15. Add the option to force sign annotated tagsLaurent Arnoud, Mar 22, 2016
  16. Junio C HamanoMar 22, 2016
  17. Laurent ArnoudMar 22, 2016
  18. Add the option to force sign annotated tagsLaurent Arnoud, Mar 22, 2016
  19. Junio C HamanoMar 21, 2016
  20. Add the tag.gpgsign option to sign annotated tagsLaurent Arnoud, Mar 21, 2016
  21. Jeff KingMar 21, 2016
  22. Jeff KingMar 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.