git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add the tag.gpgsign option to sign all created tags

From
Jeff King <peff@peff.net>
Date
Mar 20, 2016, 16:52 UTC
Message-ID
<20160320165216.GA5710@sigill.intra.peff.net>
In-Reply-To
<20160320122023.GA5139@spk-laptop>
On Sun, Mar 20, 2016 at 01:20:23PM +0100, Laurent Arnoud wrote:
Show 9 quoted lines
> Hi Jeff,
> 
> On Sun, Mar 20, 2016 at 12:29:12AM -0400, Jeff King wrote:
> > We have commit.gpgsign, so this makes some sense. Would you want to sign
> > _all_ tags created with "git tag", including lightweight tags, or only
> > those that would already create a tag object (i.e., annotated tags)?
> 
> Yes those that create a tag object (annotated tags).
> All you suggestions make sense and I will prepare a patch v2.

That behavior makes more sense to me, but I don't think it's what your patch does (v1 or v2). Perhaps it would make sense to add some tests, both to verify that it is behaving as expected, and to protect that behavior from future changes?

-Peff
Previous: Laurent ArnoudNext: Laurent Arnoud
Message 4 of 22 in “Add the tag.gpgsign option to sign all created tags”
  1. Add the tag.gpgsign option to sign all created tagsLaurent Arnoud, Mar 19, 2016
  2. Jeff KingMar 20, 2016
  3. Laurent ArnoudMar 20, 2016
  4. Jeff KingMar 20, 2016
  5. Laurent ArnoudMar 20, 2016
  6. Add the tag.gpgsign option to sign all created tagsLaurent Arnoud, Mar 20, 2016
  7. Ramsay JonesMar 20, 2016
  8. Junio C HamanoMar 21, 2016
  9. Laurent ArnoudMar 21, 2016
  10. Junio C HamanoMar 21, 2016
  11. Laurent ArnoudMar 21, 2016
  12. Jeff KingMar 21, 2016
  13. Add the tag.gpgsign option to sign annotated tagsLaurent Arnoud, Mar 21, 2016
  14. Junio C HamanoMar 21, 2016
  15. Add the option to force sign annotated tagsLaurent Arnoud, Mar 22, 2016
  16. Junio C HamanoMar 22, 2016
  17. Laurent ArnoudMar 22, 2016
  18. Add the option to force sign annotated tagsLaurent Arnoud, Mar 22, 2016
  19. Junio C HamanoMar 21, 2016
  20. Add the tag.gpgsign option to sign annotated tagsLaurent Arnoud, Mar 21, 2016
  21. Jeff KingMar 21, 2016
  22. Jeff KingMar 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.