Re: [PATCH v2] Add the tag.gpgsign option to sign all created tags
- From
Jeff King <peff@peff.net>
- Date
- Mar 21, 2016, 20:04 UTC
- Message-ID
- <20160321200451.GA32071@sigill.intra.peff.net>
- In-Reply-To
- <xmqqvb4fliq6.fsf@gitster.mtv.corp.google.com>
On Mon, Mar 21, 2016 at 12:43:45PM -0700, Junio C Hamano wrote:
Show 20 quoted lines
> If so, then the configuration is "when the user gives us a message > to create a tag without explicitly saying -a/-s, we create an > annotated tag by default, but create a signed tag instead in such a > case", I would think. That is: > > $ git tag -m 'foo' $tagname > > would create signed tag under such a configuration option, and I > think such an option may make sense. And the way to override it > would be > > $ git tag -a -m 'foo' $tagname > > So there is no need for --no-sign option. When the user explicitly > asks to create an annotated tag with > > $ git tag -a -m 'foo' $tagname > > it is unreasonable to override that explicit wish with a > configuration setting.
FWIW, of the schemes discussed in this thread, this one makes the most sense to me (and is one I might actually use).
I think you could shoe-horn it into my "tag-type" config scheme as a new mode ("sign-if-message" or something), but I think it is much clearer as a standalone config variable.
Thanks for a dose of sanity.
-Peff