git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] t0060: basename("//") is implementation defined

From
Torsten Bögershausen <tboegi@web.de>
Date
Jan 14, 2016, 11:47 UTC
Message-ID
<56978ADF.5040401@web.de>
In-Reply-To
<alpine.DEB.2.20.1601140758420.2964@virtualbox>
On 01/14/2016 08:00 AM, Johannes Schindelin wrote:
Show 21 quoted lines
> Hi Torsten,
>
> On Wed, 13 Jan 2016, tboegi@web.de wrote:
>
>> diff --git a/test-path-utils.c b/test-path-utils.c
>> index 4ab68ac..db0bb39 100644
>> --- a/test-path-utils.c
>> +++ b/test-path-utils.c
>> @@ -142,7 +142,9 @@ static struct test_data dirname_data[] = {
>>   	{ ".",               "."      },
>>   	{ "..",              "."      },
>>   	{ "/",               "/"      },
>> +#if defined(NO_LIBGEN_H)
>>   	{ "//",              "//"     },
>> +#endif
> This would miss faulty implementations that return completely bogus
> outputs for the "//" input. Not very likely, I agree, but the entire
> intention of this regression test is to verify that Git's expectations are
> met (and to document those expectations).
>
> I hope you like the alternative patch I just sent out.
Yepp, looks good. Thanks for the work.
Previous: Johannes Schindelin
Message 4 of 4 in “t0060: basename("//") is implementation defined”
  1. t0060: basename("//") is implementation definedtboegi@web.de, Jan 13, 2016
  2. Junio C HamanoJan 13, 2016
  3. Johannes SchindelinJan 14, 2016
  4. Torsten BögershausenJan 14, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.