From: Torsten Bögershausen <tboegi@web.de>
Date: Thu, 14 Jan 2016 11:47:43 GMT
Subject: Re: [PATCH/RFC] t0060: basename("//") is implementation defined
Message-ID: <56978ADF.5040401@web.de>
In-Reply-To: <alpine.DEB.2.20.1601140758420.2964@virtualbox>

On 01/14/2016 08:00 AM, Johannes Schindelin wrote:
> Hi Torsten,
>
> On Wed, 13 Jan 2016, tboegi@web.de wrote:
>
>> diff --git a/test-path-utils.c b/test-path-utils.c
>> index 4ab68ac..db0bb39 100644
>> --- a/test-path-utils.c
>> +++ b/test-path-utils.c
>> @@ -142,7 +142,9 @@ static struct test_data dirname_data[] = {
>>   	{ ".",               "."      },
>>   	{ "..",              "."      },
>>   	{ "/",               "/"      },
>> +#if defined(NO_LIBGEN_H)
>>   	{ "//",              "//"     },
>> +#endif
> This would miss faulty implementations that return completely bogus
> outputs for the "//" input. Not very likely, I agree, but the entire
> intention of this regression test is to verify that Git's expectations are
> met (and to document those expectations).
>
> I hope you like the alternative patch I just sent out.
Yepp, looks good. Thanks for the work.