Re: [PATCH/RFC] t0060: basename("//") is implementation defined

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 14, 2016, 07:00 UTC
Message-ID: <alpine.DEB.2.20.1601140758420.2964@virtualbox>
In-Reply-To: <1452718561-32226-1-git-send-email-tboegi@web.de>

Hi Torsten,

On Wed, 13 Jan 2016, tboegi@web.de wrote:

Show 11 quoted lines

> diff --git a/test-path-utils.c b/test-path-utils.c
> index 4ab68ac..db0bb39 100644
> --- a/test-path-utils.c
> +++ b/test-path-utils.c
> @@ -142,7 +142,9 @@ static struct test_data dirname_data[] = {
>  	{ ".",               "."      },
>  	{ "..",              "."      },
>  	{ "/",               "/"      },
> +#if defined(NO_LIBGEN_H)
>  	{ "//",              "//"     },
> +#endif

This would miss faulty implementations that return completely bogus outputs for the "//" input. Not very likely, I agree, but the entire intention of this regression test is to verify that Git's expectations are met (and to document those expectations).

I hope you like the alternative patch I just sent out.

Ciao, Dscho