git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 00/10] object_id part 2

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Aug 2, 2015, 23:33 UTC
Message-ID
<55BEA8E4.7040902@alum.mit.edu>
In-Reply-To
<1434233803-422442-1-git-send-email-sandals@crustytoothpaste.net>
On 06/14/2015 12:16 AM, brian m. carlson wrote:
Show 13 quoted lines
> This is another series of conversions to struct object_id.
> 
> This series converts more of the refs code and struct object to use
> struct object_id.  It introduces an additional helper function,
> has_object_file, which is the equivalent of has_sha1_file.  The name was
> chosen to be slightly more logical than has_oid_file, although it can be
> changed if desired.
> 
> The next-to-last patch in this series is the conversion of struct object
> to use struct object_id.  This is a necessarily large patch because of
> the large number of places this code is used.  That patch will most
> likely be too large to make it through to the list, so this series is
> available in the object-id-part2 branch from:
FWIW I've skimmed patches 01-08 inclusive and nothing jumped out at me.

Brian, what was your experience when writing these patches? Did they tend to work as soon as they compiled without errors (i.e., not super risky) or did you often have test suite failures that you had to go back and fix (i.e., risky)? If the latter, what kinds of code patterns tended to be problematic? Your answers might help reviewers decide how much diligence is needed when reviewing these patches and what kind of changes to inspect extra carefully. Because doing a thorough review of all of the patches would be quite a bit of work.

Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
Previous: brian m. carlsonNext: brian m. carlson
Message 12 of 13 in “object_id part 2”
  1. 00/10 object_id part 2brian m. carlson, Jun 13, 2015
  2. 01/10 refs: convert some internal functions to use object_idbrian m. carlson, Jun 13, 2015
  3. 02/10 sha1_file: introduce has_object_file helper.brian m. carlson, Jun 13, 2015
  4. 03/10 Convert struct ref to use object_id.brian m. carlson, Jun 13, 2015
  5. Junio C HamanoJun 15, 2015
  6. 04/10 add_sought_entry_mem: convert to struct object_idbrian m. carlson, Jun 13, 2015
  7. 05/10 parse_fetch: convert to use struct object_idbrian m. carlson, Jun 13, 2015
  8. 06/10 get_remote_heads: convert to struct object_idbrian m. carlson, Jun 13, 2015
  9. 07/10 push_refs_with_export: convert to struct object_idbrian m. carlson, Jun 13, 2015
  10. 08/10 ref_newer: convert to use struct object_idbrian m. carlson, Jun 13, 2015
  11. 10/10 remote: convert functions to struct object_idbrian m. carlson, Jun 13, 2015
  12. Michael HaggertyAug 2, 2015
  13. brian m. carlsonAug 3, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.