git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 00/10] object_id part 2

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Aug 3, 2015, 23:45 UTC
Message-ID
<20150803234536.GC581651@vauxhall.crustytoothpaste.net>
In-Reply-To
<55BEA8E4.7040902@alum.mit.edu>
On Mon, Aug 03, 2015 at 01:33:56AM +0200, Michael Haggerty wrote:
Show 8 quoted lines
> Brian, what was your experience when writing these patches? Did they
> tend to work as soon as they compiled without errors (i.e., not super
> risky) or did you often have test suite failures that you had to go back
> and fix (i.e., risky)? If the latter, what kinds of code patterns tended
> to be problematic? Your answers might help reviewers decide how much
> diligence is needed when reviewing these patches and what kind of
> changes to inspect extra carefully. Because doing a thorough review of
> all of the patches would be quite a bit of work.

In this particular branch, I think I may have had one bad patch. (I'm trying to recall because I've been working on patches for part 3 in the mean time, and they all seem to group together.) In general, over all my patches, the conversions I've had to fix the most have been the ones to use the GIT_SHA1_* constants, because it's very easy to get off-by-one errors in there or mess up the values such that things break. Extra effort on those, or additional suggestions on how to make them cleaner and less brittle, both now and in the future, would be welcome.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Previous: Michael Haggerty
Message 13 of 13 in “object_id part 2”
  1. 00/10 object_id part 2brian m. carlson, Jun 13, 2015
  2. 01/10 refs: convert some internal functions to use object_idbrian m. carlson, Jun 13, 2015
  3. 02/10 sha1_file: introduce has_object_file helper.brian m. carlson, Jun 13, 2015
  4. 03/10 Convert struct ref to use object_id.brian m. carlson, Jun 13, 2015
  5. Junio C HamanoJun 15, 2015
  6. 04/10 add_sought_entry_mem: convert to struct object_idbrian m. carlson, Jun 13, 2015
  7. 05/10 parse_fetch: convert to use struct object_idbrian m. carlson, Jun 13, 2015
  8. 06/10 get_remote_heads: convert to struct object_idbrian m. carlson, Jun 13, 2015
  9. 07/10 push_refs_with_export: convert to struct object_idbrian m. carlson, Jun 13, 2015
  10. 08/10 ref_newer: convert to use struct object_idbrian m. carlson, Jun 13, 2015
  11. 10/10 remote: convert functions to struct object_idbrian m. carlson, Jun 13, 2015
  12. Michael HaggertyAug 2, 2015
  13. brian m. carlsonAug 3, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.